Skip to content

Conversation

@derickr
Copy link
Member

@derickr derickr commented Jun 10, 2025

No description provided.

@github-actions
Copy link
Contributor

🚀 Regression report for commit 44c91c2 is at https://web-php-regression-report-pr-1277.preview.thephp.foundation

@github-actions
Copy link
Contributor

🚀 Preview for commit 44c91c2 can be found at https://web-php-pr-1277.preview.thephp.foundation

Comment on lines +82 to +87
<div class="example"><div class="example-contents screen"><pre>
sudo apt -y install software-properties-common
sudo add-apt-repository ppa:ondrej/php
sudo apt update
sudo apt install php{$version}
</pre></div></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using PPAs is Ubuntu-specific. For Debian the repository should be set up as per: https://packages.sury.org/php/README.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need to work on all of these. And probably also stick them in files.

Comment on lines +82 to +87
<div class="example"><div class="example-contents screen"><pre>
sudo apt -y install software-properties-common
sudo add-apt-repository ppa:ondrej/php
sudo apt update
sudo apt install php{$version}
</pre></div></div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need to work on all of these. And probably also stick them in files.

'php82' => '8.2',
'php81' => '8.1',
default => '8.4'
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "routing" needs to be more clever, likely.

<?= option('osvariant', 'linux-rpm-redhat', 'RedHat'); ?>
<?= option('osvariant', 'osx-latest', 'Latest'); ?>
<?= option('osvariant', 'windows-wsl', 'with WSL'); ?>
<?= option('osvariant', 'windows-normal', 'without WSL'); ?>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefixes are important here for disabling/enabling based on OS.

@derickr
Copy link
Member Author

derickr commented Jul 3, 2025

Superseded by #1287

@derickr derickr closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants