Update phpdoc-parser to ^3.0 on Reflection v3 branch#721
Open
dmsnell wants to merge 8 commits intophpDocumentor:3.0from
Open
Update phpdoc-parser to ^3.0 on Reflection v3 branch#721dmsnell wants to merge 8 commits intophpDocumentor:3.0from
dmsnell wants to merge 8 commits intophpDocumentor:3.0from
Conversation
From 6d612e49f15e11b79644e486467e7da73e7bb8c8 in sirreal/phpdoc-parser
dmsnell
changed the title
dmsnell
force-pushed
the
fix/update-parser
branch
from
3bbeeff to
aaaf8f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library has been in use to generate the documentation at https://developer.wordpress.org. Unfortunately, a while ago, that processed failed due to new syntax used in WordPress’ codebase. The syntax, which failed in
nikic/phpdoc-parser@^1.0is resolved innikic/phpdoc-parser@^3.0with minimal patching here.Newer versions of the PHP parser require more work to update, while v4 of this library requires substantial change to the WordPress code.
This patch proposes making the minimal changes to
Reflectionon the old branch which allow WordPress to restart generating its documentation, and it makes it possible not only to parse the source code, but to run the process on newer versions of PHP (which due to the dependencies are currently locked at 7.2).