feat: Add optional template caching support to EnvironmentBuilder#1294
Open
CybotTM wants to merge 3 commits intophpDocumentor:mainfrom
Open
feat: Add optional template caching support to EnvironmentBuilder#1294CybotTM wants to merge 3 commits intophpDocumentor:mainfrom
CybotTM wants to merge 3 commits intophpDocumentor:mainfrom
Conversation
Add a $cacheDir parameter to enable Twig's built-in template caching. When provided, compiled templates are stored on disk and reused, avoiding recompilation on every render. Performance impact: ~25% faster template rendering for repeated builds. - New parameter: $cacheDir (string|false, default: false) - When false (default): no caching (backward compatible) - When string: compiled templates cached to that directory - auto_reload enabled: templates recompile when source changes This is a backward-compatible change - existing code continues to work without modification.
10 tasks
Tests cover: - Environment creation without caching (default) - Environment creation with cache directory - Debug extension is always enabled - Custom extensions are properly added - Context setting adds global variable - Auto-reload is enabled for development - setEnvironmentFactory replaces environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
$cacheDirparameter toEnvironmentBuilderto enable Twig's built-in template caching. When provided, compiled templates are stored on disk and reused, avoiding recompilation on every render.Changes
Behavior
$cacheDirvaluefalse(default)'/tmp/twig'The
auto_reloadoption is enabled, so templates automatically recompile when the source file changes.Performance Impact
~25% faster template rendering for repeated builds, especially beneficial for:
Backward Compatibility
This is fully backward compatible:
falsepreserves current behaviorUsage Example
Test Plan