fix: resolve cross-page fragment links in markdown#1300
Open
jonathanhefner wants to merge 1 commit intophpDocumentor:mainfrom
Open
fix: resolve cross-page fragment links in markdown#1300jonathanhefner wants to merge 1 commit intophpDocumentor:mainfrom
jonathanhefner wants to merge 1 commit intophpDocumentor:mainfrom
Conversation
Markdown links with both a page reference and a fragment anchor like `[text](page-b.md#section-two)` failed to resolve, producing a warning: "Reference page-b.md#section-two could not be resolved". Two independent bugs caused this: 1. `LinkParser` checked `str_ends_with($url, '.md')` on the full URL including the fragment, so `page-b.md#section-two` did not match and the `.md` extension was never stripped. Fix: split the fragment off before the `.md` check, then reattach it afterward. 2. `PageHyperlinkResolver` passed the full target reference (including `#fragment`) to `findDocumentEntry()`, which always returned `null` since no document is keyed with a fragment suffix. Fix: split the fragment before the document lookup and append it to the generated URL, matching the pattern already used by `DocReferenceResolver`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown links with both a page reference and a fragment anchor like
[text](page-b.md#section-two)failed to resolve, producing a warning: "Reference page-b.md#section-two could not be resolved".Two independent bugs caused this:
LinkParsercheckedstr_ends_with($url, '.md')on the full URL including the fragment, sopage-b.md#section-twodid not match and the.mdextension was never stripped. Fix: split the fragment off before the.mdcheck, then reattach it afterward.PageHyperlinkResolverpassed the full target reference (including#fragment) tofindDocumentEntry(), which always returnednullsince no document is keyed with a fragment suffix. Fix: split the fragment before the document lookup and append it to the generated URL, matching the pattern already used byDocReferenceResolver.