Run tests for PHP 8.4 #1493
Open
Run tests for PHP 8.4 #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelloDuarte
approved these changes
Jun 22, 2025
|
@MarcelloDuarte thanks, I will review the failures |
|
@MarcelloDuarte please approve the potential fix |
MarcelloDuarte
approved these changes
Jul 13, 2025
|
@MarcelloDuarte psalm errors fixed 🤞 |
|
ping @MarcelloDuarte |
|
@MarcelloDuarte looks ready for release, wdyt? |
Jean85
approved these changes
Aug 10, 2025
| @@ -105,6 +105,7 @@ private function lineIsInsideMethod(int $line, ReflectionMethod $method): bool | |||
| private function addErrorThrowingExampleToSuite(Resource $resource, Suite $suite, \Error $error) : void | |||
| { | |||
| $reflection = new ReflectionClass(ErrorSpecification::class); | |||
| /** @var ReflectionClass<Specification> $reflection */ | |||
There was a problem hiding this comment.
This PHPDoc seems superfluous, $reflection is already of this type (even more specific).
Suggested change
| /** @var ReflectionClass<Specification> $reflection */ |
There was a problem hiding this comment.
I had to add it to make psalm happy IIRC.
There was a problem hiding this comment.
I tested it locally and it worked fine. Maybe it was needed before other changes were done? BTW it's just redundant, so not a blocker for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully final step for 8.4 readiness (#1477).
@MarcelloDuarte could you please approve?