fix(lib): Addresses GHSA-rg36-rxv9-2m9q vulnerability - #274
Open
mfdebian wants to merge 2 commits into
Open
Conversation
Ref: GHSA-rg36-rxv9-2m9q ------- Co-authored-by: EQSTLab <148991397+EQSTLab@users.noreply.github.com> Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com> Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> (cherry picked from commit 1f67ecf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses GHSA-rg36-rxv9-2m9q
Backports
1f67ecffrommasterto5.0.This backport brings
5.0to parity with whatmasterships today.The fix is @UlisesGascon work and he is preserved as author of
b290fac, along with the originalCo-authored-bytrailers and the(cherry picked from commit 1f67ecf...)line. He is additionally listed as aCo-authored-bytrailer so that credit survives a squash merge, which would otherwise reassign authorship to me (I think?). Only the tests are (my) new work, and they are isolated in their own commit.Just as a disclaimer: I did use Claude Code to test this changes locally and it found an issue in the current
v4.3.0version in which (since the substitution runs in a callback invoked fromWaiter.resolve()outside thetry/catchinrender_file) there's a possibility an exception throws and terminates the process; Express error middleware cannot intercept it and no HTTP response is sent. I will be opening an issue with that info after opening this PR. It did give me a reproducible example (that I will share on that issue) but I (sadly) haven't had the time to double check the proposed (by Claude) fix for it just yet. While I'm terrified of opening AI slop issues, since I was able to reproduce this one locally, I'd rather have it documented somewhere and worst case scenario, if it doesn't really apply, we just close it. This branch is unaffected by that issue.