-
Notifications
You must be signed in to change notification settings - Fork 8
[Improvement]: Improve processing of generic data index queue #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139a547
to
b0a7d07
Compare
@mcop1 Please make sure the required reviewer is assigned. |
lukmzig
approved these changes
Sep 18, 2025
|
markus-moser
approved these changes
Sep 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #337
Resolves https://github.com/pimcore/service-operations/issues/173
Resolves #343
Additional info
Improvements adapted from #337
id
column with auto_increment as pkelementType
andelementId
(former pk)FOR UPDATE SKIP LOCKED
)Additional improvements
type
filter when selecting related ids for data objects. This will allow better use of data base indexes.affectedRows
: Updating the chunk will happen only if the insert returned affected rows lower than the actual chunk size.delete
statement to include theid
column,order by
andlimit
.Note: Delete operation isnt async for now, since we cant access the deleted element in the backend anymore. To achieve this, more refactoring is needed.