Skip to content

pass arguments properly to invoke #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

pass arguments properly to invoke #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65fcb07
pass arguments properly to invoke
bernieke Mar 9, 2021
e5a1f57
fix test
bernieke Mar 9, 2021
8492119
Merge branch 'main' into master
bernieke Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,9 @@ def test_invoke_command(runner, tmpdir):
path.write("default_command = flush\n", "a")

flush = mock.MagicMock()
parser = mock.MagicMock()
flush.make_parser.return_value = parser
parser.parse_args.return_value = {}, [], []
with patch.dict(cli.commands, values={"flush": flush}):
result = runner.invoke(cli, catch_exceptions=False)

Expand Down
8 changes: 6 additions & 2 deletions todoman/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,14 @@ def cli(click_ctx, colour, porcelain, humanize, config):


def invoke_command(click_ctx, command):
name, *args = command.split(" ")
name, *raw_args = command.split(" ")
if name not in cli.commands:
raise click.ClickException("Invalid setting for [main][default_command]")
click_ctx.invoke(cli.commands[name], args)
parser = cli.commands[name].make_parser(click_ctx)
opts, args, param_order = parser.parse_args(raw_args)
for param in param_order:
opts[param.name] = param.handle_parse_result(click_ctx, opts, args)[0]
click_ctx.invoke(cli.commands[name], *args, **opts)


try: # pragma: no cover
Expand Down