Skip to content

fix port handling behavior on localhost 8000 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix port handling behavior on localhost 8000 #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a31cca8
fix port handling behavior on localhost 8000
Jun 4, 2025
25f8da1
format and code quality
Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/pingintel_api/sov_fixer/sov_fixer_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import click

from pingintel_api.api_client_base import APIClientBase
from urllib.parse import urlparse, urlunparse

from ..utils import is_fileobj, raise_for_status
from . import types as t
Expand Down Expand Up @@ -134,6 +135,25 @@ def fix_sov_download(
if not output_url.startswith("http"):
assert output_url.startswith("/"), f"Invalid output URL: {output_url}"
output_url = self.api_url + output_url
else:
# Ensure output_url uses the same port as self.api_url
api_parts = urlparse(self.api_url)
output_parts = urlparse(output_url)
api_port = api_parts.port
if api_port and (output_parts.port != api_port):
netloc = output_parts.hostname
if api_port:
netloc += f":{api_port}"
Comment on lines +145 to +146
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for 'api_port' on line 145 is redundant given the preceding condition on line 143. Consider removing it to simplify the code.

Suggested change
if api_port:
netloc += f":{api_port}"
netloc += f":{api_port}"

Copilot uses AI. Check for mistakes.
output_url = urlunparse(
(
output_parts.scheme,
netloc,
output_parts.path,
output_parts.params,
output_parts.query,
output_parts.fragment,
)
)

if self.environment and self.environment == "local2" and "api-local.sovfixer.com" in output_url:
output_url = output_url.replace("api-local.sovfixer.com", "localhost:8000")
Expand Down