Skip to content

Fixed incorrect projection #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed incorrect projection #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aa05d0
Added test case panning
stevenwithaph Aug 10, 2025
eabed27
Removed duplicate projection
stevenwithaph Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions examples/demo/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,23 @@
initialize();
};

let panPos = undefined;

Check warning on line 128 in examples/demo/basic.js

View workflow job for this annotation

GitHub Actions / build 

It's not necessary to initialize 'panPos' to undefined

app.canvas.addEventListener('mousemove', (e) => {

Check warning on line 130 in examples/demo/basic.js

View workflow job for this annotation

GitHub Actions / build 

Opening curly brace appears on the same line as controlling statement
if (!panPos) return;

app.stage.position.x += e.pageX - panPos.x;
app.stage.position.y += e.pageY - panPos.y;
panPos = { x: e.pageX, y: e.pageY };
});

app.canvas.addEventListener('mousedown', (e) => {

Check warning on line 138 in examples/demo/basic.js

View workflow job for this annotation

GitHub Actions / build 

Opening curly brace appears on the same line as controlling statement
panPos = { x: e.pageX, y: e.pageY };
});

app.canvas.addEventListener('mouseup', (e) => {

Check warning on line 142 in examples/demo/basic.js

View workflow job for this annotation

GitHub Actions / build 

Opening curly brace appears on the same line as controlling statement
panPos = undefined;
});

runApp();
})();
3 changes: 1 addition & 2 deletions src/TilemapPipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ export class TilemapPipe implements RenderPipe<Tilemap>, InstructionPipe<Tilemap
let anim_frame = this.tileAnim;
const { u_anim_frame } = pipe_uniforms.uniforms;

u_global.uProjectionMatrix.copyTo(u_proj_trans).append(u_global.uWorldTransformMatrix)
.append(tilemap.worldTransform);
u_global.uProjectionMatrix.copyTo(u_proj_trans).append(tilemap.worldTransform);
if (tilemap.compositeParent)
{
anim_frame = (tilemap.parent as CompositeTilemap).tileAnim || anim_frame;
Expand Down