Skip to content

Conversation

ipula
Copy link
Contributor

@ipula ipula commented Mar 4, 2025

see #11014 , #11026 , #11016

@ipula ipula marked this pull request as ready for review March 4, 2025 21:27
@ipula ipula force-pushed the ipula/i11026 branch 4 times, most recently from 3e54608 to 039dd17 Compare March 6, 2025 19:42
Copy link
Contributor

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ipula! Just some minor changes here.

@ipula ipula force-pushed the ipula/i11026 branch 2 times, most recently from 81de54f to 2785bd9 Compare March 31, 2025 09:30
@ipula ipula requested a review from ewhanson March 31, 2025 09:32
Copy link
Contributor

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, @ipula!

@ewhanson
Copy link
Contributor

@ipula, is there a matching PR for this and pkp/ui-library#549 for the stable-3_5_0 branch?

@ipula
Copy link
Contributor Author

ipula commented Mar 31, 2025

@ipula, is there a matching PR for this and pkp/ui-library#549 for the stable-3_5_0 branch?

No there is not. If you want I can create a PR with these changes to stable-3_5_0 both pkp-lib and ui-library

@ewhanson
Copy link
Contributor

ewhanson commented Apr 4, 2025

@ipula, yes could you do that? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants