pkp/pkp-lib#11557 Use single format for keywords in publication object

[ajnyga]

No description provided.

[touhidurabir]

Hi @ajnyga , added some initial comments, nothing critical . But I am unable to test the PR locally as it seems bit behind the current state , Need a rebase with latest version . I will do more detail review once it's rebased and tests are passing(as failing in unit test) .

BTW on thing we need some decide on retrieving the specific key like name again from DB or directly from the publication object to reduce DB calls .

[ajnyga]

I think the failing unit tests have something todo with using the publication object to fetch the keywords and subjects in dc11?

[ajnyga]

I noticed now that I missed one direct call to the getBySymbolic in classes/search/ArticleSearch.php

However, I changed the new logic for fetching data from the publication object to other places and if the approach is ok I can add it to ArticleSearch as well.

The unit test like I mention above is probably due to the way the test is written. I am not that familiar with the unittests part of the application though. The dc11 itself seems to work ok when you look for example the oai endpoint. I will study the unittests more carefully and will try to suggest a new implementation for that.