pkp/pkp-lib#11732 Add tests for public comments #11810
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
taslangraham
force-pushed
the
i11732-main
branch
from
60f29a8 to
7becd41
Compare
taslangraham
force-pushed
the
i11732-main
branch
from
7becd41 to
a25bb8c
Compare
taslangraham
force-pushed
the
i11732-main
branch
from
a25bb8c to
b9379e4
Compare
ewhanson
requested changes
Oct 8, 2025
There was a problem hiding this comment.
Thanks @taslangraham, just a few questions. Once you have a look at those, feel free to merge!
| it('should enable public commenting', () => { | ||
| cy.login('rvaca'); | ||
|
|
||
| cy.visit('http://localhost:8000/index.php/publicknowledge/en/management/settings/website#content'); |
There was a problem hiding this comment.
Should this also just be index.php/publicknowledge/en/management/settings/website#content?
| .should('be.visible').type(`${testCommentText} - ${index + 1}`); | ||
| cy.contains('button.BaseCommentsNewSubmit', 'Submit').click(); | ||
|
|
||
| cy.wait(1000); |
There was a problem hiding this comment.
A general comment on these, not this one specifically, but did you find you needed a whole second of waiting here? I noticed there are quite a few and they add up. If they're all necessary, no problem, but just wanted to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11732