Credit Roles #644
Credit Roles #644
Conversation
jyhein
commented
Jun 13, 2025
jyhein
commented
- Adds Credit Roles and degrees of contribution to contributor form and landing page
- Adds 2 db tables
- Downloads translations
| {{ t('submission.submit.creditRoles.description', {}) }} | ||
| </div> | ||
| <div class="pkpFormField__control pkpFormField--creditRoles__control"> | ||
| <PkpTable aria-label="Credit Roles"> |
There was a problem hiding this comment.
This one needs be localised. I see you followed the FieldAffiliation, where its also not localised.. will address that.
There was a problem hiding this comment.
Can you follow the improvements I just did to the FieldAffiliation to follow same pattern? I think thats best fit here.
ff9c645#diff-a7100dddb36405c9a76f5469cce92e8186a9122a3c4e14568aa63f60fed85aaa
| @@ -0,0 +1,133 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Can you please add it also to the storybook?
Have we had designs for it? Just wondering if there is reference for me to look at.
There was a problem hiding this comment.
There was a problem hiding this comment.
How is it added to the storybook?
There was a problem hiding this comment.
Checkout FieldAffiliations.stories.js for example
There was a problem hiding this comment.
Ok. How do I test stories? I haven't done this before
There was a problem hiding this comment.
@jardakotesovec , I added the storybook
jyhein
force-pushed
the
f857_credit
branch
2 times, most recently
from
92deb00 to
6003915
Compare
There was a problem hiding this comment.
@jyhein Thank you for the updates, looking great. Sorry for delay, just returned from the vacation.
