-
Notifications
You must be signed in to change notification settings - Fork 52
pkp/pkp-lib#11576 Add backoffice UI for comment moderation #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
020656f
to
544abf1
Compare
544abf1
to
575d86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks good, my comments are more about functionality/design as noted below:
- Ambiguity between "needs approval" and "hidden" is somewhat confusing in the parent list. It's unclear at a glance if something has been intentionally hidden or is simply awaiting approval. This may be worked out in the processes of UI/UX design work.
- It's a little confusing when handling a report. The "action" isn't clear in this context (unchecking the box doesn't feel very active for "handling" or "processing" a report). I also initially thought the parent list wasn't refreshing when I closed the modal for the report because the report action didn't remove or change the report item in the list.
- Modals do no close when actions are completed, again allowing for possible confusion on whether the action "went through."
Just adding a note here that we've decided on having a discussion with @Devika008 about these and other UI considerations before moving forward. |
53a85e4
to
0235314
Compare
79e11ad
to
13004f0
Compare
- Allows parent component to control which tab is active
3791f73
to
3ca12a3
Compare
3ca12a3
to
38bd907
Compare
For pkp/pkp-lib#11576