Skip to content

pkp/pkp-lib#11576 Add backoffice UI for comment moderation #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

taslangraham
Copy link
Contributor

@taslangraham taslangraham force-pushed the i11576-main branch 4 times, most recently from 020656f to 544abf1 Compare July 18, 2025 19:43
@taslangraham taslangraham marked this pull request as ready for review July 18, 2025 19:45
@ewhanson ewhanson self-requested a review July 18, 2025 21:35
Copy link
Contributor

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code looks good, my comments are more about functionality/design as noted below:

  • Ambiguity between "needs approval" and "hidden" is somewhat confusing in the parent list. It's unclear at a glance if something has been intentionally hidden or is simply awaiting approval. This may be worked out in the processes of UI/UX design work.
  • It's a little confusing when handling a report. The "action" isn't clear in this context (unchecking the box doesn't feel very active for "handling" or "processing" a report). I also initially thought the parent list wasn't refreshing when I closed the modal for the report because the report action didn't remove or change the report item in the list.
  • Modals do no close when actions are completed, again allowing for possible confusion on whether the action "went through."

@taslangraham
Copy link
Contributor Author

taslangraham commented Jul 22, 2025

Overall the code looks good, my comments are more about functionality/design as noted below:

  • Ambiguity between "needs approval" and "hidden" is somewhat confusing in the parent list. It's unclear at a glance if something has been intentionally hidden or is simply awaiting approval. This may be worked out in the processes of UI/UX design work.
  • It's a little confusing when handling a report. The "action" isn't clear in this context (unchecking the box doesn't feel very active for "handling" or "processing" a report). I also initially thought the parent list wasn't refreshing when I closed the modal for the report because the report action didn't remove or change the report item in the list.
  • Modals do no close when actions are completed, again allowing for possible confusion on whether the action "went through."

Just adding a note here that we've decided on having a discussion with @Devika008 about these and other UI considerations before moving forward.

@taslangraham taslangraham marked this pull request as draft July 31, 2025 16:58
@taslangraham taslangraham marked this pull request as ready for review August 18, 2025 15:29
@taslangraham taslangraham force-pushed the i11576-main branch 3 times, most recently from 79e11ad to 13004f0 Compare August 20, 2025 15:50
@taslangraham taslangraham force-pushed the i11576-main branch 2 times, most recently from 3791f73 to 3ca12a3 Compare August 20, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants