pkp/pkp-lib#9295 continuous publication implementation update #683
+712
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touhidurabir
force-pushed
the
i9295_update_main
branch
3 times, most recently
from
59b21c7 to
b3f6fcf
Compare
touhidurabir
commented
Aug 18, 2025
| if (data.value) { | ||
| const options = data.value.map((option) => ({ | ||
| value: option.value, | ||
| label: option.label, |
There was a problem hiding this comment.
probably should apply JS version stripUnsafeHtml here .
touhidurabir
commented
Aug 18, 2025
Comment on lines
+254
to
+261
| watch( | ||
| selectedAssignmentType, | ||
| () => { | ||
| // Trigger validation update when assignment type changes | ||
| // which ensures validationErrors computed property updates | ||
| }, | ||
| {immediate: true}, | ||
| ); |
There was a problem hiding this comment.
this probably not needed anymore .
…status as STATUS_READY_TO_PUBLISH
touhidurabir
force-pushed
the
i9295_update_main
branch
from
836ca9b to
6966b39
Compare
touhidurabir
force-pushed
the
i9295_update_main
branch
from
6966b39 to
0f61ced
Compare
|
@jardakotesovec, sending to you for review. |
|
@asmecher I would prefer not to merge this version, and still make the adjustments to use existing form fields, and not creating new field which combines multiple fields. Example I provided is available on these PRs.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for pkp/pkp-lib#9295 , second batch of PRs to update the implementation to
publishedcolumn inpublicationstablestatuscolumn ofpublicationstable by introducing a new statusPKPSubmission::STATUS_READY_TO_PUBLISH