Fix marshalling of empty oneOf messages #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmg
approved these changes
Mar 8, 2024
Contributor
vmg
left a comment
vmg
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you!
howardjohn
added a commit
to howardjohn/vtprotobuf
that referenced
this pull request
Apr 8, 2024
planetscale#130 did not correctly account for the key size impacting the size. This fixes the original PR, and adds another test case to cover the issue
|
hi @vmg wondering if there is any chance to do a release including this commit, a patch would work out great also open to help out in any way we can :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
This seems to pass all tests, but I am not super confident without #129 passing