Skip to content

feat: add support for postgres bindings #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

enko
Copy link
Contributor

@enko enko commented Jul 4, 2025

No description provided.

@Qard
Copy link
Member

Qard commented Jul 7, 2025

Looks like libpq is missing on macOS? I think installing postgresql in brew just gets you the server, not the client. 🤔

@Qard Qard added the enhancement New feature or request label Jul 7, 2025
@enko
Copy link
Contributor Author

enko commented Jul 7, 2025

@Qard whats really strange is that the x86 macos build did work 🤔

https://github.com/platformatic/php-node/actions/runs/16079798020/job/45385034353?pr=49

I will have a look later why that might be the case.

@Qard
Copy link
Member

Qard commented Jul 7, 2025

Ah, yeah, that is strange.

I'm pretty sure I actually had it building at one point locally. I did test against a bunch of other extensions, but we reduced the set down to just what was needed to get the main frameworks working. (Wordpress, Laravel, etc.)

Of course we're happy to support additional extensions as users have need of them though, so we can for sure get this landed once CI works. 🙂

@enko
Copy link
Contributor Author

enko commented Jul 7, 2025

I managed to get the PHP build locally. But I used Postgres 16 I see now. I decided to use 14 because that is what is inside the Ubuntu side. Let me try.

@enko
Copy link
Contributor Author

enko commented Jul 7, 2025

Success:

checking for libpq >= 10.0... no
checking for pg_config... not found
configure: error: in '/Users/tsc/datenknoten/dev/php-src':
configure: error: Cannot find libpq-fe.h or pq library (libpq). Please specify the correct
PostgreSQL installation path with environment variables PGSQL_CFLAGS and
PGSQL_LIBS or provide the PostgreSQL installation directory.
See 'config.log' for more details

Let me try 16.

Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs nit, but otherwise LGTM. 🙂

@enko enko force-pushed the add-postgres-support branch 2 times, most recently from 15cfd4b to abee6ca Compare July 8, 2025 07:20
@enko enko force-pushed the add-postgres-support branch from abee6ca to 057fc5c Compare July 8, 2025 07:21
@Qard Qard merged commit 4ff36f4 into platformatic:main Jul 9, 2025
11 checks passed
@Qard Qard mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants