Migrate to http-handler and http-rewriter #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
use-http-crate
branch
4 times, most recently
from
9d08bda to
6038900
Compare
Qard
force-pushed
the
use-http-crate
branch
11 times, most recently
from
dc56fa2 to
459ceb9
Compare
The CI downloads artifacts to npm/<platform>/binding.node but the code was only looking for php.<platform>.node in the root directory. This change tries the npm directory first (for CI/published builds) and falls back to the root path (for local development builds). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Qard
force-pushed
the
use-http-crate
branch
2 times, most recently
from
94bbf39 to
90cc532
Compare
Rename the Rust crate and library from php-node/php_node to php for better clarity and consistency. Updated all references throughout the codebase including doctests. Changes: - Cargo.toml: Changed package name from 'php-node' to 'php' - Cargo.toml: Changed lib name from 'php_node' to 'php' - src/lib.rs: Updated doctest to use 'php::' instead of 'php_node::' - src/embed.rs: Updated all doctests to use 'php::' prefix - src/main.rs: Updated imports to use 'php::' prefix - CLAUDE.md: Updated documentation to reflect single-crate structure and removed references to old multi-crate workspace All tests pass with the new naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.