-
-
Notifications
You must be signed in to change notification settings - Fork 96
Integrating Nuclia Widget #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nuclia
Are you sure you want to change the base?
Conversation
This reverts commit b4533ea.
Removed run on requirements-initial.txt
…o nuclia_widget
…o nuclia_widget
…o nuclia_widget
…o nuclia_widget
Here's that git command from Volto that builds only when docs change: |
Remove lesscpy from requirements.txt
Use no-tracking url of youtube
There's an error in the CI: https://github.com/plone/training/actions/runs/11968576684/job/33367643251?pr=792 |
@stevepiercy my guess would be the |
@stevepiercy yes that was missing. |
Thanks @ebrehault. I was looking for them in https://github.com/plone/training/settings/variables/actions, and |
Oops, there it is! nm. |
@ebrehault the CI still fails. It looks like the action is not picking up the value for https://github.com/plone/training/actions/runs/11968576684/job/33370147780#step:5:11 |
Ah, I see, it's a repo var, not a secret. |
Still failing, but now it is looking more like a Nuclia SDK version thing, let me check. |
I have no clue what this failure message means.
Where do we get the git hash? |
Answering my own question. CHANGED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }}) Next question, are these the correct values to use? It rejected |
@justdaksh where did you get |
I read about it from StackOverflow at that time, but I can't find the reference to it right now. |
From a comment in that SO post, I found this: https://github.com/actions/checkout?tab=readme-ov-file#checkout-v4:
Commit incoming. We'll see. |
- Set fetch-depth: 0 to fetch all history for all branches and tags
That seems to have done the trick. |
This looks promising and is well advanced. When can we get it finished and installed? I played with the search. Feedback
|
It's one of my highest priorities for Plone docs, but I have three Plone projects ahead of this item. The release of Plone Sphinx Theme 2.0.0 is one of them and is a partial blocker to this issue, since it will remove Sphinx Book Theme from the dependency stack. That said, I don't think the removal of Sphinx Book Theme will have a significant impact, except possibly some CSS rules. I'll be busy through the end of March. I'd welcome any help to see this through. |
CC: @stevepiercy
Here is a draft for Nuclia widget integration into training.
Some of the issues to be solved:
Pull request preview URL:
https://plone-training--792.org.readthedocs.build/