-
-
Notifications
You must be signed in to change notification settings - Fork 96
Update customizing VLT #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
"plone.api", | ||
"plone.restapi", | ||
"plone.volto", | ||
"kitconcept.voltolighttheme==7.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shoule be 7.3.1 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
Now let's add VLT's powerful widgets to control block width and alignment. Update the schema file to add the schema enhancer. | ||
|
||
Update `src/components/blocks/myHero/schema.js`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema.ts instead of js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@danalvrz I went through all the code of exercise. I found some issue in hero block
![]() |
@danalvrz Fixed . |
Sorry, I won't have time to give this a thorough review before the training tomorrow I would strongly suggest that you perform the following checks to make sure you don't have any glaring errors or warnings.
|
To enable site customization through the UI: | ||
|
||
1. Go to http://localhost:3000/controlpanel/dexterity-types/Plone%20Site | ||
2. In the "Behaviors" tab, activate the desired behaviors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently following the training at Plone conf. At this point I am wondering what the behaviours are that the VLT add-on adds. So a list would be nice.
Or a link to the backend add-on repo, as new behaviours may be added in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @mauritsvanrees - It is extremely difficult to get the origin of the new behaviours explicitly from the description. I can guess them after watching a demo the same day, but this is not sustainable.
|
||
export default function install(config: ConfigType) { | ||
// Block palettes | ||
config.blocks.themes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation:
config.blocks.themes = [ | |
config.blocks.themes = [ |
|
||
### Step 4: Register the Basic Block | ||
|
||
Update `src/config/blocks.ts`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused a bit of confusion in the training. Do we need to replace the existing blocks.ts
completely with the next code? No.
Update `src/config/blocks.ts`: | |
Edit `src/config/blocks.ts`. | |
At the top add a few imports from the new hero block. | |
Inside the `install` function, register the hero block: |
|
||
Now let's add VLT's powerful widgets to control block width and alignment. Update the schema file to add the schema enhancer. | ||
|
||
Update `src/components/blocks/myHero/schema.ts`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update `src/components/blocks/myHero/schema.ts`: | |
Replace `src/components/blocks/myHero/schema.ts`: |
Minor typographical corrections and other contributions that are not "material in nature" are exempt from this requirement.
glossary.md
and referenced them in the documentation. Note that terms that are defined in external Sphinx documentation, including Plone 6 documentation, may be referenced with a{term}
directive without adding the definition to the localglossary.md
file.If your pull request closes an open issue, include the exact text below, immediately followed by the issue number.
When your pull request gets merged, then that issue will close automatically.
Closes #
📚 Documentation preview 📚: https://plone-training--978.org.readthedocs.build/