-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add tickmode "proportional" #6827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ayjayt
wants to merge
38
commits into
plotly:master
Choose a base branch
from
geopozo:pikul-proportional-ticks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e7a2ffa
Add/calc tickmode "proportional" in `cartesian/`
ayjayt 6d48a3b
Fix bug by which tickvals forever expands
ayjayt 00e884a
Make tickmode proportional calculate reversed axes
ayjayt 931199e
Use lib.simpleMap(); Refactor var names.
ayjayt fced9ce
Add log math to tickmode proportional
ayjayt b2abf08
Remove console debug messages
ayjayt 910163e
Add description in layout_attributes.js
ayjayt e21af96
Fix linter errors
ayjayt ddfaad7
update plot-scheme diff
ayjayt d42dd73
Restore proportional array later in loop:
ayjayt 5d7b1b9
Remove _isSet flag from tickVals before resetting
ayjayt db1f82e
Add parameterized tests:
ayjayt a2ac023
Fix tests to pass if #6828 is addressed
ayjayt 1fedfc7
Clean up commenting/address lint errors.
ayjayt e8f2052
Fix a bit more lint
ayjayt c3f590d
Merge branch 'master' into pikul-proportional-ticks
ayjayt 7e93370
Change tickmode 'proportional' to 'domain array'
ayjayt afba178
Add tickmode 'full domain'
ayjayt aca7a92
Set default so `full domain` doesn't set to `auto`
ayjayt 195dfa5
Fix various errata/typos
ayjayt a788ccc
Add test for full-domain
ayjayt ecffc49
Merge branch 'master' into pikul-proportional-ticks
ayjayt 3089c4a
Restructure parameterization and fix linting
ayjayt 99d336a
Intermediate commit w/ partial work- new strat:
ayjayt 4476d38
Merge branch 'master' into pikul-proportional-ticks
ayjayt 3502d49
Revert branch to equal master
ayjayt 09ebcfc
Lint and refactor
ayjayt 3fe254b
Merge branch 'pikul-proportional-ticks-old' into pikul-proportional-t…
ayjayt eb82723
Revert completely to old tick algo
ayjayt fe6f8d0
update git-scheme diff
ayjayt b3956a0
Merge branch 'master' into pikul-proportional-ticks
ayjayt 7176049
Remove category test in prep for disallowing
ayjayt 15387ed
Refactor as to not override ax.tickvals:
ayjayt 2ab0b41
Rework some if-then to golf mode (?:)
ayjayt f1a4db8
Lint
ayjayt ee17af2
Make 'auto' to function as 'array' when [] present
ayjayt 93e4bb8
Refix incorrect patch ee17af22f393c
ayjayt 61efdef
Merge branch 'master' into pikul-proportional-ticks
ayjayt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.