Skip to content

Conversation

michalbiesek
Copy link

@michalbiesek michalbiesek commented Feb 13, 2020

  • add pmem_memset and pmem_memcpy PMEM_F_MEM_NODRAIN
    PMEM_F_MEM_NONTEMPORAL

This change is Reviewable

- add pmem_memset and pmem_memcpy PMEM_F_MEM_NODRAIN
PMEM_F_MEM_NONTEMPORAL
@michalbiesek michalbiesek marked this pull request as ready for review February 14, 2020 08:56
Copy link

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jschmieg)

Copy link

@guoanwu guoanwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the zmemcpy_pmem(s,init,initlen); then s[initlen]='\0'; that will cause the cache miss, we can call s[initlen]='0' before the zmemcpy_pmem

@michalbiesek
Copy link
Author

Job continue in #163

@michalbiesek michalbiesek deleted the feat-pmem-memcpy branch April 1, 2020 14:44
PatKamin added a commit to PatKamin/redis that referenced this pull request Sep 27, 2022
[4.0.0-devel] Fix tarball naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants