SdsMakeRoom always in DRAM #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces 2 variants for SdsMakeRoom funtion: on DRAM and General Can be used in networking.c
michalbiesek
suggested changes
Jul 9, 2020
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jschmieg and @kasiawasiuta)
src/sds.c, line 249 at r1 (raw file):
s_realloc(sh, hdrlen+newlen+1);
Just an question you don't want to cover this case? with distinction for general variant and DRAM ?
|
Can one of the admins verify this patch? |
PatKamin
added a commit
to PatKamin/redis
that referenced
this pull request
Oct 28, 2022
[5.0.3-devel] Fix make test failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces 2 variants for SdsMakeRoom funtion: on DRAM and General
Can be used in networking.c
This change is