Skip to content

Conversation

@jugonzal07
Copy link
Contributor

First cut at a Section 12 Rule 5 rule test JSON for both 90.1-2019 and 90.1-2022

@yunjoonjung-PNNL
Copy link
Collaborator

yunjoonjung-PNNL commented Oct 27, 2025

Juan - Good work. Can you please check the following?

  1. The annual_site_energy_use object shouldn't be under the output_instance object. Can we remove the output_instance object?
  2. There is a space `at the end of the ``annual_site_energy_use``` object. can we remove the space?
  3. We need the latent_fraction key.

@jugonzal07
Copy link
Contributor Author

Juan - Good work. Can you please check the following?

  1. The annual_site_energy_use object shouldn't be under the output_instance object. Can we remove the output_instance object?
  2. There is a space `at the end of the ``annual_site_energy_use``` object. can we remove the space?
  3. We need the latent_fraction key.

Thanks Yun Joon,

It looks like things changed a bit since I wrote this test. Can you explain point 1? That seems to be where the RPD suggests it goes

  1. Easy enough to fix
  2. I will add that to 0

Also, I believe the updated RDS requires that I add a baseline as well. I'll look to do that.

@yunjoonjung-PNNL
Copy link
Collaborator

@jugonzal07 - Could you see if the following makes sense to you?

  1. Case (b) Proposed - We need the multiplier_schedule and power keys under the miscellaneous_equipment.
  2. Case (C) Proposed - We need the type key that isn't one of the ["MISC_EQUIPMENT", "INDUSTRIAL_PROCESS", "OFFICE_EQUIPMENT", "COMPUTER_SERVERS", "COMMERCIAL_COOKING"].

After changing this, all cases passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants