RS/YJ/Rule_12-5 (2022) #1863
RS/YJ/Rule_12-5 (2022) #1863
Conversation
|
Dependency on #1846 |
weilixu
left a comment
weilixu
left a comment
There was a problem hiding this comment.
Left comments to address
| "$.buildings[*].building_segments[*].zones[*].spaces[*].miscellaneous_equipment[*]", | ||
| rmd_p, | ||
| ) | ||
| ][0], |
There was a problem hiding this comment.
Why there is [0] at the end of the list? Also, the sum here will just flatten this 2D array, instead of sum it into a value.
I think this schedule_eflh_p shall be a dictionary, in which the key is the schedule ID and the value is the sum of the hourly value?
| loads_included_p = ( | ||
| misc_equip_p["power"] > 0 * ureg("W") | ||
| and misc_equip_p["sensible_fraction"] > 0 | ||
| and misc_equip_p["latent_fraction"] > 0 |
There was a problem hiding this comment.
In RDS, it says: and (misc_equipment_p.sensible_fraction > 0 or misc_equipment_p.latent_fraction > 0)
There was a problem hiding this comment.
Addressed.
…set-checking-tool into RS/YJ/Rule_12-5
|
Is this ready for review? @yunjoonjung-PNNL |
@weilixu - No not yet because I need to test the rule, but I've got an error running the run_ruletests.py script. I'll ask the issue during our standup today and finalize this rule. |
I haven't tested this rule yet.