Add support for package.json5 format#191
Open
kokoichi206 wants to merge 4 commits intopnpm:masterfrom
Open
Conversation
KSXGitHub
requested changes
Dec 6, 2025
src/install-pnpm/run.ts
Outdated
Comment on lines
67
to
68
| ? YAML.parse(content, { merge: true }) | ||
| : JSON.parse(content) | ||
| : JSON5.parse(content) |
Collaborator
There was a problem hiding this comment.
You should change the logic into the following:
- If the file name ends with
.yaml, useYAML. - If the file name ends with
.json5, useJSON5. - Otherwise, use
JSON.
IIRC, pnpm only uses JSON5 for package.json5.
Author
There was a problem hiding this comment.
@KSXGitHub
Thank you for the review.
Fixed in be2217e.
Co-authored-by: Khải <hvksmr1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
package.json5format when reading thepackageManagerfield, making this action consistent with pnpm's own support for JSON5.Motivation
According to pnpm's documentation:
This action already supports
package.jsonandpackage.yaml, but notpackage.json5. This PR adds the missing support to be consistent with pnpm itself.Changes
json5package as a dependencyJSON5.parse()instead ofJSON.parse()for non-YAML filespackage.json5support