Misc signal cleanup #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix test msg
- Remove proc 'exit' handler during interrupt
This code was a no-op as spawn.js does not emit `exit` events.
This is actually good, because were it to be working, it would
result in a race condition when a child exits non-zero:
1. The lifecycle promise would be rejected, leading to log output
and a possible pnpm exit
2. This hook would force node to exit 0 immediately.
- Fix the listener removals when child exits.
zkochan
approved these changes
Aug 12, 2025
isaacl
added a commit
to isaacl/npm-lifecycle
that referenced
this pull request
Aug 16, 2025
This reverts the behavioral change from pnpm#41. This change caused pnpm to improperly handle interactive shell Ctrl-C, traping the received signal and also ignoring the abnormal exit of the script. This often results still in a quick exit (because the script has terminated), but with exit code 0. PR pnpm#41 behavior resulted in incorrect behavior, which also diverges from npm (as well as `node --run`). As another problem, it made pnpm internally inconsistent as Ctrl-C results in non-zero in situations when lifecycles scripts are not actively running. Even in the context of pnpm run, a very quick Ctrl-C, prior to spawn, results in a non-zero pnpm exit. For additional discussion see: pnpm#51 Fixes: pnpm/pnpm#9626
isaacl
added a commit
to isaacl/npm-lifecycle
that referenced
this pull request
Aug 16, 2025
This reverts the behavioral change from pnpm#41. This change caused pnpm to improperly handle interactive shell Ctrl-C, trapping the received signal and also ignoring the abnormal exit of the script. This often results still in a quick exit (because the script has terminated), but with exit code 0. PR pnpm#41 resulted in incorrect behavior, which also diverges from npm (as well as `node --run`). As another problem, it made pnpm internally inconsistent as Ctrl-C results in non-zero in situations when lifecycles scripts are not actively running. Even in the context of pnpm run, a very quick Ctrl-C, prior to spawn, results in a non-zero pnpm exit. For additional discussion see: pnpm#51 Fixes: pnpm/pnpm#9626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test msg
Remove proc 'exit' handler during interrupt
This code was a no-op as spawn.js does not emit
exitevents.This is actually good, because were it to be working, it would
result in a race condition when a child exits non-zero:
and a possible pnpm exit
Fix the listener removals when child exits.