Move define.TempDirForURL() to pkg/tmpdir.ForURL(), unify its and Add()'s http client configurations - #6441
Open
nalind wants to merge 2 commits into
Open
Move define.TempDirForURL() to pkg/tmpdir.ForURL(), unify its and Add()'s http client configurations#6441nalind wants to merge 2 commits into
nalind wants to merge 2 commits into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@nalind, did you intend to use the name |
Contributor
Author
|
Yeah, it's used by |
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
October 21, 2025 21:02
462f4f3 to
20c9435
Compare
Contributor
Author
|
Moved those bits to a new |
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
October 22, 2025 18:52
20c9435 to
dedabe6
Compare
Contributor
Author
|
Tweaked a bit to expose the proxy setting directly for callers. |
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
October 22, 2025 19:22
dedabe6 to
dd78138
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
December 5, 2025 15:25
dd78138 to
4f37ec2
Compare
Honny1
reviewed
Apr 17, 2026
| return fmt.Errorf("no contents in %q", url) | ||
| } | ||
| if err := chrootarchive.Untar(resp.Body, dir, nil); err != nil { | ||
| resp1, err := http.Get(url) |
| type URLOptions struct { | ||
| CertPath string // location of CA certificates, if not the system default | ||
| InsecureSkipTLSVerify types.OptionalBool | ||
| Proxy func(*http.Request) (*url.URL, error) |
Contributor
There was a problem hiding this comment.
I am not sure about the behavior of not setting the Proxy option. Maybe it should be checked or documented.
Contributor
Author
There was a problem hiding this comment.
Adding godoc for it.
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
April 20, 2026 15:04
4f37ec2 to
97063cb
Compare
dosubot
Bot
added
the
size:XL
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
April 21, 2026 15:08
97063cb to
605059d
Compare
Move the generic "download a thing" function to a package that wasn't originally intended to only include type definitions, but leave a wrapper in the old location for compatibility's sake. Fix a couple of stray spots where we still weren't using the version of the original function that accepted a context.Context. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
September 18, 2026 20:13
605059d to
eb871fd
Compare
Make sure that tmpdir.ForURL() and Add() use the same HTTP client configurations, both for TLS and proxies, so that we apply the same settings when fetching build contexts that we do for ADD instructions. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
September 18, 2026 20:46
eb871fd to
b1ca50b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The HTTP client configurations used by Add() and the logic that we use for pulling down build contexts that are specified using URLs differ in their setup, and the latter doesn't implement the --tls-verify=false flag.
How to verify it
New integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This is also a follow-up to #6274.
This moves the function that we use for retrieving things and putting them into temporary directories into its own package, but leaves behind an API-compatible wrapper function.
Does this PR introduce a user-facing change?