Skip to content

Conversation

@nhussein11
Copy link
Collaborator

@nhussein11 nhussein11 commented Oct 16, 2025

Closes 1022

πŸ“ Description

Provide a clear and concise description of your changes.

πŸ” Review Preference

Choose one:

  • βœ… I have time to handle formatting/style feedback myself
  • ⚑ Docs team handles formatting (check "Allow edits from maintainers")

πŸ€– AI-Ready Docs

If content changed, regenerate AI files:

  • βœ… I ran python3 scripts/generate_llms.py
  • ⚑ Docs team will regenerate (check "Allow edits from maintainers")

βœ… Checklist

@nhussein11 nhussein11 self-assigned this Oct 16, 2025
@nhussein11 nhussein11 requested a review from a team as a code owner October 16, 2025 12:54
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A0 - New Content Pull request contains new content pages labels Oct 16, 2025
Copilot AI review requested due to automatic review settings October 28, 2025 13:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive migration guide for Ethereum developers moving smart contracts to Polkadot Hub. The guide covers both REVM and PolkaVM backends, explaining when to use each and what changes may be required.

Key changes:

  • New migration guide document covering FAQs and considerations for Ethereum contract migration
  • Documentation of backend-specific requirements (REVM vs. PolkaVM)
  • Guidance on factory contracts, gas costs, and development tooling

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
smart-contracts/for-eth-devs/migration.md New migration guide replacing TODO placeholder with comprehensive content on migrating Ethereum contracts to Polkadot Hub
llms.txt Updated to include new migration guide entry and removed erroneous Python package license reference
llms-full.txt Regenerated AI file with full migration guide content and removed Python package license content
llms-files/llms-smart-contracts.txt Regenerated smart contracts AI file with migration guide content

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@0xlukem 0xlukem requested a review from eshaben October 30, 2025 17:17
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review too thoroughly because I feel like this page will change quite a bit when it gets reviewed to remove the PVM stuff. Not a problem for today. But we should make a few of these minor changes

Comment on lines +15 to +23
Before migrating your contracts, review this checklist:

- Standard ERC-20, ERC-721, ERC-1155 tokens work without changes.
- DeFi protocols, DEXs, and AMMs migrate seamlessly.
- DAOs and governance contracts are fully compatible.
- Most Solidity contracts deploy identically to Ethereum.
- Factory contracts using PVM bytecode need pre-uploaded dependencies.
- Contracts using `EXTCODECOPY` for runtime manipulation require review (for projects that will use PVM bytecode, not EVM bytecode).
- Replace `transfer()` and `send()` with proper reentrancy guards (for projects that will use PVM bytecode, not EVM bytecode).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is framed as a checklist, like these are tasks, but "Standard ERC-20, ERC-721, ERC-1155 tokens work without changes" isn't a task, it's a statement. So we need to reframe this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list items should all align, they should all either be tasks or they should all either be statements.

If we need to split this up into two sections, like "Considerations" and "Migration checklist" that could work

### Which Solidity features are not supported?
For REVM, Solidity features are supported.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird statement, like which Solidity features? That's what the question is asking. All of them?

### Can I use my existing development tools?
Yes! Both backends support:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Yes! Both backends support:
Yes. Both backends support:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0 - New Content Pull request contains new content pages B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants