-
Notifications
You must be signed in to change notification settings - Fork 71
Add deploy basic contract (new IA) #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/product-ia
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive deployment documentation for basic smart contracts to Polkadot Hub, splitting the content into two separate guides: one for PolkaVM (PVM) deployment and one for standard EVM deployment. Each guide covers four deployment methods: Ethers.js, Remix IDE, Hardhat, and Foundry.
Key Changes:
- Created two new deployment guides with distinct tooling paths (PVM vs EVM)
- Removed the placeholder TODO file
- Updated navigation to reflect the new structure
Reviewed Changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
smart-contracts/cookbook/smart-contracts/deploy-basic.md |
Removed placeholder TODO file |
smart-contracts/cookbook/smart-contracts/deploy-basic-pvm.md |
Added comprehensive PVM deployment guide using resolc compiler |
smart-contracts/cookbook/smart-contracts/deploy-basic-evm.md |
Added comprehensive EVM deployment guide using standard Solidity compiler |
smart-contracts/cookbook/smart-contracts/.nav.yml |
Updated navigation structure to include both PVM and EVM guides |
llms.txt |
Regenerated AI file with updated documentation links |
llms-full.txt |
Regenerated full AI file with complete documentation content |
llms-files/llms-smart-contracts.txt |
Regenerated smart contracts AI file with new guides |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice read. I see four tutorials in this deploy a basic contract tutorial:
- an Ethers.js tutorial,
- a Remix IDE tutorial,
- a Hardhat tutorial,
- and a Foundry tutorial
We can move forward as is, however it would be nice to circle back to this and split this up into separate sub-pages.
| Install Foundry: | ||
|
|
||
| ```bash | ||
| curl -L https://foundry.paradigm.xyz | bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are just grabbing the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with hardhat
| ```bash | ||
| mkdir hardhat-deployment | ||
| cd hardhat-deployment | ||
| npx hardhat --init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This install hardhat? If so, we are just grabbing the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a standard hardhat that is very stable so versioning should not be a problem
β¦exact package versions and enhancing next steps with links to ERC-20 and NFT deployment guides on Polkadot Hub.
Co-authored-by: Bruno Galvao <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only really reviewed the ethers.js guide and quickly looked at the other ones. My comments apply to all the guides, so please go back through and make the updates to those pages too. Thanks!
In smart-contracts/get-started.md we have a reference to [Deploy a Basic Contract](/smart-contracts/cookbook/smart-contracts/deploy-basic/), can you please update the link to point to the first guide in this section?
smart-contracts/cookbook/smart-contracts/deploy-basic-contract-evm/deploy-basic-ethers-js.md
Outdated
Show resolved
Hide resolved
smart-contracts/cookbook/smart-contracts/deploy-basic-contract-evm/deploy-basic-ethers-js.md
Outdated
Show resolved
Hide resolved
smart-contracts/cookbook/smart-contracts/deploy-basic-contract-evm/deploy-basic-ethers-js.md
Outdated
Show resolved
Hide resolved
smart-contracts/cookbook/smart-contracts/deploy-basic-contract-evm/deploy-basic-ethers-js.md
Outdated
Show resolved
Hide resolved
smart-contracts/cookbook/smart-contracts/deploy-basic-contract-evm/deploy-basic-ethers-js.md
Outdated
Show resolved
Hide resolved
smart-contracts/cookbook/smart-contracts/deploy-basic-contract-evm/deploy-basic-ethers-js.md
Outdated
Show resolved
Hide resolved
|
|
||
| - Deploy an ERC-20 token on Polkadot Hub, either using the [Deploy an ERC-20](/smart-contracts/cookbook/smart-contracts/deploy-erc20) guide or the [Deploy an ERC-20 to Polkadot Hub](/smart-contracts/cookbook/smart-contracts/deploy-erc20) guide. | ||
| - Deploy an NFT on Polkadot Hub, either using the [Deploy an NFT](/smart-contracts/cookbook/smart-contracts/deploy-nft) guide or the [Deploy an NFT to Polkadot Hub](/smart-contracts/cookbook/smart-contracts/deploy-nft) guide. | ||
| - Check out in details each [development environment](/smart-contracts/dev-environments/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do they get from doing this?
π Description
Provide a clear and concise description of your changes.
π Review Preference
Choose one:
π€ AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.pyβ Checklist