Skip to content

Fix- Key management section #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix- Key management section #1128

wants to merge 2 commits into from

Conversation

@nhussein11
Copy link
Collaborator

@nhussein11 nhussein11 commented Oct 21, 2025 •
edited
Loading

Solves #1050

📝 Description

Provide a clear and concise description of your changes.

🔍 Review Preference

Choose one:

  • ✅ I have time to handle formatting/style feedback myself
  • ⚡ Docs team handles formatting (check "Allow edits from maintainers")

🤖 AI-Ready Docs

If content changed, regenerate AI files:

  • ✅ I ran python3 scripts/generate_llms.py
  • ⚡ Docs team will regenerate (check "Allow edits from maintainers")

✅ Checklist

@nhussein11
Enhance key management documentation for validators by adding session…
7657911 
… key setup instructions and a link to the guide for moving funds to the Relay Chain. Update the session key submission steps in Polkadot.js Apps for clarity. Replace outdated image with an updated version.
@nhussein11 nhussein11 linked an issue Oct 21, 2025 that may be closed by this pull request
Kusama: SetSessionKeys Section Appears Outdated/Misaligned with post Asset Hub Migration #1050
Open
brunopgalvao
brunopgalvao approved these changes Oct 22, 2025
View reviewed changes
@nhussein11 nhussein11 mentioned this pull request Oct 22, 2025
Open
@deigenvektor
Copy link
Contributor

deigenvektor commented Oct 31, 2025

Since my review comment apparently does not show:
gh_review

@nhussein11
Copy link
Collaborator Author

nhussein11 commented Nov 3, 2025

Since my review comment apparently does not show: gh_review

Thank you @deigenvektor! So probably the comments have not been sent because they are marked as "pending", so it's likely that you missed clicking on "Submit Review"

Regarding the proof field, I've been researching a bit, and in all the tests shown in the polkadot-sdk repo, they use vec![] for that field (which is equivalent to 0x0). I'm not sure what the purpose of this field is, but if you agree, I could add a note saying something like: "You can simply pass 0x0 for the proof field." Would you agree with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunopgalvao brunopgalvao brunopgalvao approved these changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kusama: SetSessionKeys Section Appears Outdated/Misaligned with post Asset Hub Migration

4 participants

@nhussein11 @deigenvektor @brunopgalvao