Skip to content

Conversation

MayaGans
Copy link
Collaborator

An idea for a refactor, we can leave this as a PR or just a branch in the repo :)

Also - the footer argument isn't working and I'm not sure why?

image

@DivadNojnarg
Copy link
Collaborator

Thanks @MayaGans. The footer isn't that important. Actually, I'll ask people to drop the tablerDash template and start with only bslib elements. The fresh-start branch contains a completly cleaned up UI with only instructions in the code to get started with the new design.

@DivadNojnarg
Copy link
Collaborator

Few comments on your version:

  • Maybe add a title in the header.
  • I would really put the select input centered and much bigger.
  • The types tags are too large. I would also likely use some shades: light grey -> 0.5, dark grey -> x2 and no damages: close to white? If we want to avoid using colors.
  • We might also want to change the graph colors: main pokemon line color would be dark grey (the default color) and the previous evolution stage would be light grey.
  • The only color I would use is for the type to better differentiate them as well as the location type (forest, caves, ....). There is a function that return the type color mapping in the code.

I can take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants