-
Notifications
You must be signed in to change notification settings - Fork 116
feat: Toasts #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gadenbuie
wants to merge
47
commits into
feat/readme-porting-from-bslib
Choose a base branch
from
feat/toasts
base: feat/readme-porting-from-bslib
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Toasts #2111
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
3ecc0e6
chore: Use `bslib@feat/toasts` and upgrade html deps
gadenbuie 2b6185b
feat: Add toast notification system
gadenbuie b068dfc
feat: Add toast API examples and comprehensive unit tests
gadenbuie ceac34a
feat: Add Toast Playwright controller and end-to-end tests
gadenbuie 1cbcba4
docs: Add toast documentation to CHANGELOG and quartodoc configs
gadenbuie 142c190
fix: Fix type error in toast unit test
gadenbuie 2c135e6
feat: Update toast example apps to match R demo
gadenbuie 10c2b65
fix: fixup custom message sending
gadenbuie 92f6502
fix: make sure close button is included correctly
gadenbuie 8678b3a
fix(example): Fixup spacing in text output
gadenbuie 501ee91
fix: Fixup example apps
gadenbuie 109ed03
feat: Add `icon` parameter to `toast()`
gadenbuie 95fbb18
chore: make upgrade-html-deps
gadenbuie abd988d
chore: make upgrade-html-deps
gadenbuie db67611
chore(toast): Take `duration_s`, store in Toast object as `duration` …
gadenbuie 114c8b4
chore: Reorganize code, don't fill in toast id on creation
gadenbuie b21c2cc
refactor: Move show_toast() logic into `as_payload()` method
gadenbuie 100b5ff
feat(express): Make toast/toast_header public from shiny.express.ui
gadenbuie fcdc2d9
fix: inspect-ai requires Python >= 3.10 (#2110)
gadenbuie 7305503
Merge branch 'main' into feat/toasts
gadenbuie bf1d566
fix: No `id` is required
gadenbuie 76e60e0
tests: fix playwright tests
gadenbuie 0ed7cd5
chore: small convenience updates to Toast controller
gadenbuie 060e34a
chore: make check-fix
gadenbuie fe7dbf2
docs: Add example to `toast_header()`
gadenbuie 174e3ff
docs: Update doc strings
gadenbuie 8d551a4
chore: format
gadenbuie f5760b5
fix: restore accidentally deleted line
gadenbuie cfa6a26
fix: override or generate a random ID in toast tagify method
gadenbuie 51b6fb2
fix: Use internal typing extensions helpers to avoid type issues on P…
gadenbuie 4baddf1
chore: make format
gadenbuie 648597c
docs(toast_header): There's an example in `toast()`
gadenbuie d9510cd
chore: format
gadenbuie 0b7d26d
docs: fixup examples
gadenbuie 5a4f657
tests: Don't test for bootstrap classes
gadenbuie 7f772d0
tests: Add snapshot tests
gadenbuie 1573bd9
chore: WHY FORMATTING WHY WHY WHY
gadenbuie 38d5c3a
chore: Apply suggestions from code review
gadenbuie 1290f77
chore: remove claude settings file
gadenbuie eea3496
docs: Add toast and toast_header to express index
gadenbuie ace163a
fix(show_toast): Accept toast, str, Tag and TagList
gadenbuie 6009fc0
chore: better comments everywhere
gadenbuie 3fc7afc
refactor: simplify building header tag
gadenbuie 3464f1a
fix(toast_header): Use `TagNode` rather than `TagChild`
gadenbuie b59e982
chore: no normalize type abstraction
gadenbuie 09a88cc
fix: correct check for `is_tag_node()`
gadenbuie a5b5c67
refactor: Restore `_normalize_toast_type()` as a helper function
gadenbuie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||
| list( | ||||||
| bslib = "rstudio/bslib@main", | ||||||
| bslib = "rstudio/bslib@feat/toasts", | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a reminder before we merge
Suggested change
|
||||||
| shiny = "rstudio/shiny@main", | ||||||
| sass = "sass", | ||||||
| htmltools = "rstudio/htmltools@main" | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.