[Legacy Sync] Fix offline upload delay #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently the Legacy sync implementation can cause delays for uploading CRUD operations made while offline.
This can happen if:
connect
method is then called.This PR triggers an upload after receiving the first PowerSync service command line. This same method is currently used by the Rust implementation.
The
handles write made while offline
test has been updated. We no longer send a keepalive immediately from the mocked service. This test would previously fail without the keepalive.