Skip to content

Add ibm_pi_volumes data source and fix ibm_pi_volume data source to use id #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add ibm_pi_volumes data source and fix ibm_pi_volume data source to use id #263

wants to merge 7 commits into from

Conversation

@ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Sep 24, 2025 •
edited
Loading

This PR adds the ibm_pi_volumes data source, and cleans up the ibm_pi_volume data source to make it more explicit that an id vs a name is preferred.

Output of acceptance testing:

--- PASS: TestAccIBMPIVolumeDataSource_basic (17.51s)
PASS

--- PASS: TestAccIBMPIVolumeDataSource_replication (19.34s)
PASS

--- PASS: TestAccIBMPIVolumesDataSourceBasic (726.67s)
PASS

@ismirlia ismirlia changed the title Volume data sources Add ibm_pi_volumes data source and fix ibm_pi_volume data source to use id Sep 25, 2025
@ismirlia ismirlia added the enhancement New feature or request label Sep 25, 2025
michaelkad
michaelkad requested changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just use name instead of volumeName

@ismirlia ismirlia requested a review from michaelkad September 26, 2025 17:14
michaelkad
michaelkad reviewed Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes

michaelkad
michaelkad previously approved these changes Sep 26, 2025
View reviewed changes
@ismirlia
Copy link
Collaborator Author

Opened: IBM-Cloud#6508, closing this one.

@ismirlia ismirlia closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelkad michaelkad michaelkad left review comments

@r-patange r-patange Awaiting requested review from r-patange

Assignees

No one assigned

Labels

Datasource enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ismirlia @michaelkad