Skip to content

Conversation

@smoogipoo
Copy link
Contributor

The condition is currently equivalent to if (str == "False" && str != "0"), i.e.:

  • default => false
  • "true" (let's assume regardless of capitalisation, though that's not the case in practice) => false
  • "1" => false
  • "0" => false
  • "false" => true

Let's... not do this whole other parsing thingamajig. We haven't needed it until now.

@smoogipoo smoogipoo requested a review from peppy November 1, 2024 08:55
@peppy peppy merged commit 001e033 into ppy:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants