Skip to content

Add StaggeredGridLayoutManager to popularPhotoList #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add StaggeredGridLayoutManager to popularPhotoList #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...main/java/com/prasan/kotlinmvvmhiltflowapp/presentation/fragment/PopularPhotosFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import androidx.fragment.app.activityViewModels
import androidx.lifecycle.Observer
import androidx.navigation.fragment.findNavController
import androidx.recyclerview.widget.RecyclerView
import androidx.recyclerview.widget.StaggeredGridLayoutManager
import androidx.recyclerview.widget.StaggeredGridLayoutManager.VERTICAL
import com.prasan.kotlinmvvmhiltflowapp.*
import com.prasan.kotlinmvvmhiltflowapp.data.datamodel.Photo
import com.prasan.kotlinmvvmhiltflowapp.data.datamodel.PhotoDetails
Expand Down Expand Up @@ -63,8 +65,9 @@ class PopularPhotosFragment : Fragment() {

@ExperimentalCoroutinesApi
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {

super.onViewCreated(view, savedInstanceState)
binding.popularPhotoList.layoutManager = StaggeredGridLayoutManager(2, VERTICAL)

binding.popularPhotoList.addOnScrollListener(object : RecyclerView.OnScrollListener() {

override fun onScrollStateChanged(recyclerView: RecyclerView, newState: Int) {
Expand Down
5 changes: 0 additions & 5 deletions app/src/main/res/layout/popular_photos_fragment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
android:id="@+id/popular_photo_list"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
android:padding="2dp"
app:layoutManager="androidx.recyclerview.widget.GridLayoutManager"
app:spanCount="2"
tools:itemCount="30"
tools:listitem="@layout/popular_photos_item" />

<ProgressBar
Expand Down
19 changes: 12 additions & 7 deletions app/src/main/res/layout/popular_photos_item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
<?xml version="1.0" encoding="utf-8"?>
<layout>

<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.cardview.widget.CardView xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:padding="8dp">
android:layout_height="wrap_content"
android:layout_margin="2dp"
app:cardBackgroundColor="@android:color/white"
app:cardCornerRadius="0dp"
app:cardPreventCornerOverlap="false">

<ImageView
android:id="@+id/popular_photo"
android:layout_width="wrap_content"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:contentDescription="@string/photo_from_popular_section"
android:layout_margin="2dp"
android:adjustViewBounds="true"
android:scaleType="fitXY"
tools:src="@drawable/ic_launcher_background" />

</FrameLayout>
</androidx.cardview.widget.CardView>
</layout>