Skip to content

consistent use of adapter base class #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

consistent use of adapter base class #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbde0be
do not redeclare $contents lexical variable
Aug 4, 2021
d8a1f0d
consistent use of adapter base class
Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions lib/Log/Any/Adapter/Log4perl.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ package Log::Any::Adapter::Log4perl;
# ABSTRACT: Log::Any adapter for Log::Log4perl

use Log::Log4perl 1.32; # bug-free wrapper_register available
use Log::Any::Adapter::Util 1.03 qw(make_method);
use base qw(Log::Any::Adapter::Base);

our $VERSION = '0.10';

# Ensure %F, %C, etc. skip Log::Any related packages
Log::Log4perl->wrapper_register(__PACKAGE__);
Log::Log4perl->wrapper_register("Log::Any::Proxy");
Log::Log4perl->wrapper_register('Log::Any::Proxy');
Log::Log4perl->wrapper_register('Log::Any::Adapter::Base');

sub init {
my ($self) = @_;
Expand All @@ -31,13 +31,7 @@ foreach my $method ( Log::Any->logging_and_detection_methods() ) {
s/critical|alert|emergency/fatal/;
}

make_method(
$method,
sub {
my $self = shift;
return $self->{logger}->$log4perl_method(@_);
}
);
__PACKAGE__->delegate_method_to_slot('logger', $method, $log4perl_method);
}

sub structured {
Expand Down
2 changes: 1 addition & 1 deletion t/log4perl.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ foreach my $method ( Log::Any->detection_methods, Log::Any->detection_aliases )

$log = Log::Any->get_logger( category => 'PackageA' );
$log->debug( 'Foo' );
my $contents = read_file("$dir/test-category.log");
$contents = read_file("$dir/test-category.log");
like $contents, qr{main:.*log4perl\.t:\d+; PackageA; DEBUG; Foo \[undef\]},
'category is logged correctly';