Skip to content

fix: fix signals are not reactive on lazy imported components.(#301) #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix: fix signals are not reactive on lazy imported components.(#301) #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export { signal, computed, batch, effect, Signal, type ReadonlySignal };
const Empty = [] as const;
const ReactElemType = Symbol.for("react.element"); // https://github.com/facebook/react/blob/346c7d4c43a0717302d446da9e7423a8e28d8996/packages/shared/ReactSymbols.js#L15
const ReactMemoType = Symbol.for("react.memo"); // https://github.com/facebook/react/blob/346c7d4c43a0717302d446da9e7423a8e28d8996/packages/shared/ReactSymbols.js#L30
const ReactLazyType = Symbol.for("react.lazy"); // https://github.com/facebook/react/blob/346c7d4c43a0717302d446da9e7423a8e28d8996/packages/shared/ReactSymbols.js#L31
const ProxyInstance = new WeakMap<
FunctionComponent<any>,
FunctionComponent<any>
Expand Down Expand Up @@ -166,6 +167,10 @@ function WrapJsx<T>(jsx: T): T {
return jsx.call(jsx, type, props, ...rest);
}

if (type && typeof type === "object" && type.$$typeof === ReactLazyType) {
return jsx.call(jsx, ProxyFunctionalComponent(type._init(type._payload)), props, ...rest);
}

if (typeof type === "string" && props) {
for (let i in props) {
let v = props[i];
Expand Down