feat: add jsxBind function to @preact/signals
#724
+182
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 4604dd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jul 12, 2025
| expect(scratch.innerHTML).to.equal("<div>Jane Doe</div>"); | ||
| }); | ||
|
|
||
| it("should update bound values without re-rendering the component", async () => { |
There was a problem hiding this comment.
Can we add a test where we first return JSX and then text or something, similar to the normal SignalValue component
|
This is missing a changeset btw |
Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Jovi De Croock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I briefly discussed this idea with @rschristian, who said I should try to implement it.
Link to discussion: https://preact.slack.com/archives/C3NMBSJKH/p1752172452437339
Goal
Avoid needing to declare "computed expressions" with
useComputed, enabling you to write "inline computeds" where they're needed. This is intended for computeds that are only used by one JSX attribute or JSX child.How It Works
It's as easy as wrapping a "computed callback" with
jsxBind(…), a function exported by the@preact/signalspackage.Key Features
useComputed, the callback does not update on rerenderCurrent Limitations
Currently, there is no warning when trying to use
jsxBindwith a composite element, as this would require iterating the props object. Maybe someone has an idea about how to efficiently check for such misuse.Naming
Originally, I named it
bind(), but decidedjsxBind()makes its purpose a bit clearer. Ultimately, the name is up to you guys. :)