Generic hf properties #355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for new downsamplable properties: `marker_symbol` and `hf_marker_symbol`. - Refactored the handling of high-frequency properties to be more dynamic and extensible. - Updated the `_hf_data_container` to include new properties and adjusted parsing logic accordingly. - Introduced tests to validate the functionality of dynamic properties and their priority over trace attributes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 83.83% 88.11% +4.28%
==========================================
Files 13 14 +1
Lines 1206 1245 +39
==========================================
+ Hits 1011 1097 +86
+ Misses 195 148 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll extend the code and tests as well to fix #320 |
|
Ready for review @jvdd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to provide a more generic interface for passing
hf_propsRelated #354
Added support for new downsamplable properties:
marker_symbolandhf_marker_symbol.Refactored the handling of high-frequency properties to be more dynamic and extensible.
Updated the
_hf_data_containerto include new properties and adjusted parsing logic accordingly.Introduced tests to validate the functionality of dynamic properties and their priority over trace attributes.
updated
ruffto improve and homogenize linting experience in CI-CD