Skip to content

Fix: DataTable issue loading prop true hides empty message #8292 #8297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: DataTable issue loading prop true hides empty message #8292 #8297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b1cbaf
Fix: DataTable: loading prop true hides empty message #8292
sarathkumarsasi Sep 22, 2025
f0932c8
Merge branch 'primefaces:master' into master
sarathkumarsasi Oct 10, 2025
0d8af20
Merge branch 'master' into master
sarathkumarsasi Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 22 additions & 26 deletions components/lib/datatable/TableBody.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,34 +910,30 @@ export const TableBody = React.memo(
});

const createEmptyContent = () => {
if (!props.loading) {
const colSpan = getColumnsLength();
const content = ObjectUtils.getJSXElement(props.emptyMessage, { props: props.tableProps, frozen: props.frozenRow }) || localeOption('emptyMessage');
const emptyMessageProps = mergeProps(
{
className: cx('emptyMessage'),
role: 'row'
},
ptm('emptyMessage')
);

const bodyCellProps = mergeProps(
{
colSpan,
role: 'cell'
},
getColumnPTOptions('root'),
getColumnPTOptions('bodyCell')
);
const colSpan = getColumnsLength();
const content = ObjectUtils.getJSXElement(props.emptyMessage, { props: props.tableProps, frozen: props.frozenRow }) || localeOption('emptyMessage');
const emptyMessageProps = mergeProps(
{
className: cx('emptyMessage'),
role: 'row'
},
ptm('emptyMessage')
);

return (
<tr {...emptyMessageProps}>
<td {...bodyCellProps}>{content}</td>
</tr>
);
}
const bodyCellProps = mergeProps(
{
colSpan,
role: 'cell'
},
getColumnPTOptions('root'),
getColumnPTOptions('bodyCell')
);

return null;
return (
<tr {...emptyMessageProps}>
<td {...bodyCellProps}>{content}</td>
</tr>
);
};

const createGroupHeader = (rowData, rowIndex, expanded, colSpan) => {
Expand Down
20 changes: 8 additions & 12 deletions components/lib/dataview/DataView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,19 +217,15 @@ export const DataView = React.memo(
};

const createEmptyMessage = () => {
if (!props.loading) {
const content = props.emptyMessage || localeOption('emptyMessage');
const emptyMessageProps = mergeProps(
{
className: cx('emptyMessage')
},
ptm('emptyMessage')
);

return <div {...emptyMessageProps}>{content}</div>;
}
const content = props.emptyMessage || localeOption('emptyMessage');
const emptyMessageProps = mergeProps(
{
className: cx('emptyMessage')
},
ptm('emptyMessage')
);

return null;
return <div {...emptyMessageProps}>{content}</div>;
};

const createHeader = () => {
Expand Down
4 changes: 0 additions & 4 deletions components/lib/treetable/TreeTableBody.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,6 @@ export const TreeTableBody = React.memo((props) => {
};

const createEmptyMessage = () => {
if (props.loading) {
return null;
}

const colSpan = props.columns ? props.columns.length : null;
const content = ObjectUtils.getJSXElement(props.emptyMessage, { props: props.tableProps }) || localeOption('emptyMessage');
const emptyMessageProps = mergeProps(
Expand Down
Loading