Replace deprecated tsdown noExternal with deps.alwaysBundle - #223
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe pull request replaces tsdown's Merge Risk: ⚪ Minimal · up to This localized change replaces a deprecated build option with its supported equivalent while preserving the existing bundling values; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tsdown 0.21.10 warns on every CI build that noExternal is deprecated. The installed version supports the replacement, so all three configs now use deps.alwaysBundle with the same values. Output is unchanged and the builds emit no warning. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
fd864bc to
5b07e32
Compare
commit: |
tsdown 0.21.10 warns on every publish build that
noExternalis deprecated. The installed version already supports the replacement, so the three configs (prisma,cli,cli-engine) now usedeps: { alwaysBundle: [...] }with the same values, and theci.tscomment that named the old option is updated. All three packages build cleanly with no warning.🤖 Generated with Claude Code