Skip to content

Replace deprecated tsdown noExternal with deps.alwaysBundle - #223

Merged
wmadden-electric merged 1 commit into
mainfrom
claude/tsdown-noexternal-deprecation-0863ee
Aug 25, 2026
Merged

Replace deprecated tsdown noExternal with deps.alwaysBundle#223
wmadden-electric merged 1 commit into
mainfrom
claude/tsdown-noexternal-deprecation-0863ee

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

tsdown 0.21.10 warns on every publish build that noExternal is deprecated. The installed version already supports the replacement, so the three configs (prisma, cli, cli-engine) now use deps: { alwaysBundle: [...] } with the same values, and the ci.ts comment that named the old option is updated. All three packages build cleanly with no warning.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 982cac19-d71d-44a6-bc00-167243c8f222

📥 Commits

Reviewing files that changed from the base of the PR and between dcde760 and 5b07e32.

📒 Files selected for processing (4)
  • packages/cli-engine/src/ci.ts
  • packages/cli-engine/tsdown.config.ts
  • packages/cli/tsdown.config.ts
  • packages/prisma/tsdown.config.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Summary by CodeRabbit

  • Chores
    • Updated build configuration to use the latest dependency-bundling settings.
    • Preserved bundling behavior for required CLI, telemetry, Prisma, and CI dependencies.
    • Updated related build-system documentation comments for consistency.

Walkthrough

The pull request replaces tsdown's noExternal option with deps.alwaysBundle in the CLI Engine, CLI, and Prisma build configurations. The configured dependency sets remain unchanged. A related comment now references the new option.

Merge Risk: ⚪ Minimal · up to 5b07e

This localized change replaces a deprecated build option with its supported equivalent while preserving the existing bundling values; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: replacing deprecated tsdown noExternal with deps.alwaysBundle.
Description check ✅ Passed The description accurately explains the deprecation warning, affected configurations, preserved behavior, and updated ci.ts comment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/tsdown-noexternal-deprecation-0863ee
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/tsdown-noexternal-deprecation-0863ee

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

tsdown 0.21.10 warns on every CI build that noExternal is deprecated. The installed version supports the replacement, so all three configs now use deps.alwaysBundle with the same values. Output is unchanged and the builds emit no warning.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric
wmadden-electric force-pushed the claude/tsdown-noexternal-deprecation-0863ee branch from fd864bc to 5b07e32 Compare August 25, 2026 06:07
@pkg-pr-new

pkg-pr-new Bot commented Aug 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@223
npx https://pkg.pr.new/@prisma/cli-engine@223

commit: 5b07e32

@wmadden-electric
wmadden-electric merged commit 228549f into main Aug 25, 2026
14 checks passed
@wmadden-electric
wmadden-electric deleted the claude/tsdown-noexternal-deprecation-0863ee branch August 25, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant