Remove the deprecated defineConfig alias before launch - #228
Closed
wmadden-electric wants to merge 1 commit into
Closed
Remove the deprecated defineConfig alias before launch#228wmadden-electric wants to merge 1 commit into
wmadden-electric wants to merge 1 commit into
Conversation
The engine's deprecated defineConfig re-export of definePrismaConfig was the only @deprecated surface in the repo. Nothing imports it: the prisma/config entry point re-exports definePrismaConfig by name, and the composer and ORM families' same-named helpers are their own. It rides the in-flight, unpublished engine 0.2.3, so no extra release chain. Doc prose that still said defineConfig now names definePrismaConfig. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Contributor
Author
|
Folded into the config-file-resolution PR per operator instruction; this branch is superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine's deprecated
defineConfigre-export ofdefinePrismaConfigwas the only@deprecatedsurface in the repository, and nothing consumes it:prisma/configre-exportsdefinePrismaConfigby name, and the composer/ORM families' same-named helpers are their own, not imports of the engine's. Removed ahead of launch, riding the in-flight unpublished engine 0.2.3 so no additional release chain is needed. Tests and doc prose follow.🤖 Generated with Claude Code