docs: restore nodejs_compat flag on Cloudflare deployment page - #8158
docs: restore nodejs_compat flag on Cloudflare deployment page#8158liamiepops wants to merge 1 commit into
Conversation
|
@liamiepops is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe Cloudflare PostgreSQL deployment instructions now use ChangesCloudflare deployment documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a localized documentation update restoring the current Cloudflare compatibility flag guidance, with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Cloudflare deployment page tells you to set
node_compat = trueinwrangler.toml. Cloudflare replaced that with thenodejs_compatcompatibility flag, and the current Prisma guide at/guides/deployment/cloudflare-workersalready uses the new form, so the two pages contradict each other.This was already fixed. #7468 made the same change on 3 February. It was lost when #7479 migrated the docs to Fumadocs on 12 February: the fixed file was renamed into
docs.v6, and the current v7 page came from a copy that still had the old text.This PR restores those changes. The
compatibility_datein the example is set to today rather than the February date.I hit this running Prisma 7.9.1 under workerd with
nodejs_compatset inwrangler.jsonc.Three things to note:
apps/docs/content/between chore(): clean up some docs content #7468 and chore(): upload new docs #7479. Four added new guides, which are unaffected. The fifth, DR-6829 DOCS: Update "seconds" to "milliseconds" for sql server file #7442, was a fix like this one, and it got lost in the merge too, so the SQL Server page reads "seconds" again instead of "milliseconds". I'm not sure what it should read though, the PostgreSQL and MySQL pages say seconds, so I'm not sure milliseconds was correct, or what the intention was there. Someone needs to untangle that one. I only checkedapps/docs/content/, so I don't know whether anything outside the docs was affected.Summary by CodeRabbit
wrangler.jsoncconfiguration example usingnodejs_compatand a compatibility date.