-
Notifications
You must be signed in to change notification settings - Fork 96
fix(skore): Don't use the Summary widget in an IPython terminal #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 cts: i don't like the fact that it fixes only the IPython context. For instance, it will not work if i amm in the python console.
I don't know if its feasible, but i would like to solve this in a general way: if the widget is displayable, display it.
Otherwise, fallback on Pandas representation. Wdyt ?
|
For the regular python console, I do get the dataframe's repr and I believe this is because whats is used is |
Fixes #2070
Check if we're in an IPython terminal and if it is the case, use DataFrame's
_repr_html_instead of Summary's widget.