added vertical margin to nav items #633
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somewhere we have a breakpoint adding a min-height to the main nav so that when the window height is small, we don't get scroll bars on the main nav, just on the section nav below it. Do we need to update that min height here too? Currently I believe it's 350px, might need to be increased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #612 by adding vertical margin to navigation items.
Margin value was picked to match
jump tosection margin value, mentioned in the issue.Branch cotaines one failing test although, it also occurs in the main branch. So I decided to leave it as-is.
Below I attached screenshots showing before and after.