Fix usage of fn in MediaElement.connect #8176
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8173
Changes:
fn
and the globalp5
in theMediaElement
class with internal methods that return undefinedMediaElement
, patches those internal methods to havefn
andp5
usageThis is a workaround to a problem that we only have because Documentation.js does not parse classes correctly when they're defined inside of an addon function. If we could do that, then we could just reference
p5
andfn
from the addon function parameters. However, because of our constraints, just patching in the relevant methods is maybe the best we can do.Live: https://editor.p5js.org/davepagurek/sketches/PN2B_ebLG
PR Checklist
npm run lint
passes