Fix: prevent uSampler uniform from being reset for user shaders #8201
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8200
Changes:
uSampleruniform was being reset to an empty texture, causing user-defined shaders to render blank.uSampleris only reset for internal p5.js shaders, not for shaders where the user manually set the uniform.fix-shader.htmlto verify the fix: drawing a red rectangle using a custom FBO shader works correctly.Screenshots of the change:
fix-shader.htmltest (previously rendered blank).PR Checklist
npm run lintpassesfix-shader.html) included